jspg stabilized again

src/database/mod.rs

@@ -2,9 +2,9 @@ pub mod edge;
 pub mod r#enum;
 pub mod executors;
 pub mod formats;
+pub mod object;
 pub mod page;
 pub mod punc;
-pub mod object;
 pub mod relation;
 pub mod schema;
 pub mod r#type;
@@ -60,7 +60,10 @@ impl Database {
             db.enums.insert(def.name.clone(), def);
           }
           Err(e) => {
-            let name = item.get("name").and_then(|v| v.as_str()).unwrap_or("unknown");
+            let name = item
+              .get("name")
+              .and_then(|v| v.as_str())
+              .unwrap_or("unknown");
             errors.push(crate::drop::Error {
               code: "DATABASE_ENUM_PARSE_FAILED".to_string(),
               message: format!("Failed to parse database enum '{}': {}", name, e),
@@ -81,7 +84,10 @@ impl Database {
             db.types.insert(def.name.clone(), def);
           }
           Err(e) => {
-            let name = item.get("name").and_then(|v| v.as_str()).unwrap_or("unknown");
+            let name = item
+              .get("name")
+              .and_then(|v| v.as_str())
+              .unwrap_or("unknown");
             errors.push(crate::drop::Error {
               code: "DATABASE_TYPE_PARSE_FAILED".to_string(),
               message: format!("Failed to parse database type '{}': {}", name, e),
@@ -106,7 +112,10 @@ impl Database {
             }
           }
           Err(e) => {
-            let constraint = item.get("constraint").and_then(|v| v.as_str()).unwrap_or("unknown");
+            let constraint = item
+              .get("constraint")
+              .and_then(|v| v.as_str())
+              .unwrap_or("unknown");
             errors.push(crate::drop::Error {
               code: "DATABASE_RELATION_PARSE_FAILED".to_string(),
               message: format!("Failed to parse database relation '{}': {}", constraint, e),
@@ -127,7 +136,10 @@ impl Database {
             db.puncs.insert(def.name.clone(), def);
           }
           Err(e) => {
-            let name = item.get("name").and_then(|v| v.as_str()).unwrap_or("unknown");
+            let name = item
+              .get("name")
+              .and_then(|v| v.as_str())
+              .unwrap_or("unknown");
             errors.push(crate::drop::Error {
               code: "DATABASE_PUNC_PARSE_FAILED".to_string(),
               message: format!("Failed to parse database punc '{}': {}", name, e),
@@ -199,7 +211,13 @@ impl Database {
   pub fn compile(&mut self, errors: &mut Vec<crate::drop::Error>) {
     let mut harvested = Vec::new();
     for (id, schema_arc) in &self.schemas {
-      crate::database::schema::Schema::collect_schemas(schema_arc, id, id.clone(), &mut harvested, errors);
+      crate::database::schema::Schema::collect_schemas(
+        schema_arc,
+        id,
+        id.clone(),
+        &mut harvested,
+        errors,
+      );
     }
     for (id, schema_arc) in harvested {
       self.schemas.insert(id, schema_arc);
@@ -208,11 +226,12 @@ impl Database {
     self.collect_schemas(errors);
 
     // Mathematically evaluate all property inheritances, formats, schemas, and foreign key edges topographically over OnceLocks
-    let mut visited = std::collections::HashSet::new();
     for (id, schema_arc) in &self.schemas {
       // First compile pass initializes exact structural root_id mapping to resolve DB constraints
       let root_id = id.split('/').next().unwrap_or(id);
-      schema_arc.as_ref().compile(self, root_id, id.clone(), &mut visited, errors);
+      schema_arc
+        .as_ref()
+        .compile(self, root_id, id.clone(), errors);
     }
   }
 
@@ -224,19 +243,37 @@ impl Database {
     for type_def in self.types.values() {
       for (id, schema_arc) in &type_def.schemas {
         to_insert.push((id.clone(), Arc::clone(schema_arc)));
-        crate::database::schema::Schema::collect_schemas(schema_arc, id, id.clone(), &mut to_insert, errors);
+        crate::database::schema::Schema::collect_schemas(
+          schema_arc,
+          id,
+          id.clone(),
+          &mut to_insert,
+          errors,
+        );
       }
     }
     for punc_def in self.puncs.values() {
       for (id, schema_arc) in &punc_def.schemas {
         to_insert.push((id.clone(), Arc::clone(schema_arc)));
-        crate::database::schema::Schema::collect_schemas(schema_arc, id, id.clone(), &mut to_insert, errors);
+        crate::database::schema::Schema::collect_schemas(
+          schema_arc,
+          id,
+          id.clone(),
+          &mut to_insert,
+          errors,
+        );
       }
     }
     for enum_def in self.enums.values() {
       for (id, schema_arc) in &enum_def.schemas {
         to_insert.push((id.clone(), Arc::clone(schema_arc)));
-        crate::database::schema::Schema::collect_schemas(schema_arc, id, id.clone(), &mut to_insert, errors);
+        crate::database::schema::Schema::collect_schemas(
+          schema_arc,
+          id,
+          id.clone(),
+          &mut to_insert,
+          errors,
+        );
       }
     }
 
@@ -276,10 +313,10 @@ impl Database {
     all_rels.sort_by(|a, b| a.constraint.cmp(&b.constraint));
 
     for rel in all_rels {
-      let mut is_forward =
-        p_def.hierarchy.contains(&rel.source_type) && c_def.hierarchy.contains(&rel.destination_type);
-      let is_reverse =
-        p_def.hierarchy.contains(&rel.destination_type) && c_def.hierarchy.contains(&rel.source_type);
+      let mut is_forward = p_def.hierarchy.contains(&rel.source_type)
+        && c_def.hierarchy.contains(&rel.destination_type);
+      let is_reverse = p_def.hierarchy.contains(&rel.destination_type)
+        && c_def.hierarchy.contains(&rel.source_type);
 
       // Structural Cardinality Filtration:
       // If the schema requires a collection (Array), it is mathematically impossible for a pure