From b49b216b362bc0ddad981fe912ca2829f007f864 Mon Sep 17 00:00:00 2001
From: Alex Groleau <agroleau@teampalmtree.com>
Date: Tue, 14 Jul 2026 16:02:41 -0400
Subject: [PATCH] fix(queryer): restrict polymorphic bounds compiler to forward
 edges only
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Resolves a query compilation bug in JSPG where reverse/incoming polymorphic
edges (where edge.forward == false, e.g. pet ➡️ cover_attachment) mistakenly
appended the destination type constraint to the parent query's WHERE clause
(e.g., producing `entity_1.type = 'attachment'` on a pet entity query,
causing it to match 0 rows and return null).

- Modifies `compile_polymorphic_bounds` in `compiler.rs` to only compile
  type checks when `edge.forward` is true. For reverse edges, the parent's
  type check does not belong on the parent table and is already implicitly
  restricted by parent ID joins.
- Updates the `fk_attachment_attachable_entity` relation in the queryer test
  fixture to correctly model a two-column polymorphic relation, ensuring
  this code path is exercised by the unit test suite.
---
 fixtures/queryer.json   | 6 ++++--
 src/queryer/compiler.rs | 3 ---
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/fixtures/queryer.json b/fixtures/queryer.json
index ddb1ac0..93c08e9 100644
--- a/fixtures/queryer.json
+++ b/fixtures/queryer.json
@@ -2461,11 +2461,13 @@
           "constraint": "fk_attachment_attachable_entity",
           "source_type": "attachment",
           "source_columns": [
-            "attachable_id"
+            "attachable_id",
+            "attachable_type"
           ],
           "destination_type": "entity",
           "destination_columns": [
-            "id"
+            "id",
+            "type"
           ],
           "prefix": "attachable"
         }
diff --git a/src/queryer/compiler.rs b/src/queryer/compiler.rs
index 8d9f8db..0a93239 100644
--- a/src/queryer/compiler.rs
+++ b/src/queryer/compiler.rs
@@ -621,9 +621,6 @@ impl<'a> Compiler<'a> {
                   if edge.forward && relation.source_columns.len() > 1 {
                     poly_col = Some(&relation.source_columns[1]); // e.g., target_type
                     table_to_alias = &relation.source_type; // e.g., relationship
-                  } else if !edge.forward && relation.destination_columns.len() > 1 {
-                    poly_col = Some(&relation.destination_columns[1]); // e.g., source_type
-                    table_to_alias = &relation.destination_type; // e.g., relationship
                   }
 
                   if let Some(col) = poly_col {